docs: refresh stale test counts (289/126 -> 290/208) across README, SUBMISSION and gallery card - #20
Merged
Merged
Conversation
The card's frontend stat went stale when PR #18 (direct vehicle manipulation) added manipulate.ts and VehiclePlacementPanel.tsx with their test files. Authoritative source is the green CI run on main (0101bde, run 30437023280): vitest reports 208 passed across 24 test files, and pytest still reports 289 passed, so the backend stat is unchanged. render-cards.yml re-renders the PNG from this spec on push.
README's Testing & CI section and SUBMISSION's accomplishments both still quoted 126 frontend tests. PR #18 (direct vehicle manipulation) added manipulate.ts and VehiclePlacementPanel.tsx with their test files, taking Vitest to 208 across 24 test files. Numbers taken from the green CI run on main (0101bde, run 30437023280), which is the same command CI gates on: - frontend job (npm run test:coverage): 208 passed (208) - python job (pytest tests/): 289 passed, 3 skipped The backend stat was re-verified and is unchanged at 289, so only the frontend number moves.
PR #19 (forensic-reconstruction register) landed on main while this branch was open and net-added one backend test, so the card's backend stat went stale too. Green CI on main (66f3d85, run 30450005723): pytest 290 passed, 3 skipped; vitest 208 passed across 24 files. Also refreshes the README line references in the spec notes: #19 added a line to README's thesis section, shifting the cited lines from 190/364 to 191/365.
upgradedev
force-pushed
the
fix/stale-doc-test-counts
branch
from
July 29, 2026 12:11
09b3ef9 to
04915e3
Compare
upgradedev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The committed docs quoted 289 backend / 126 frontend tests. Both are stale:
frontend/src/lib/manipulate.tsandfrontend/src/components/VehiclePlacementPanel.tsxwith their test files.
this branch was open and net-added one backend test.
README.md:191— quickstart commentREADME.md:356— Testing & CIREADME.md:365— Testing & CIdemo/SUBMISSION.md:79— Accomplishmentsdemo/assets/claimscene-07-architecture.png— gallery cardWhere the numbers come from
Not a local run. Both are the summary lines of the green CI run on current
main(
66f3d85, run 30450005723) —the exact commands CI gates on:
pythonjob (pytest tests/) →290 passed, 3 skipped, coverage 96.20%frontendjob (npm run test:coverage) →Tests 208 passed (208)across 24 test filesnpx vitest runlocally on main's frontend independently reproduces 208 passed (24 files).The gallery card
Regenerated the way the repo intends rather than by hand: the spec
demo/assets/src/claimscene-07-architecture.patch.jsonwas updated (new_text289→290,126→208), and.github/workflows/render-cards.ymlre-rendered the PNG in CI and committedit back. Render log confirms both stats drawn:
Commits are ordered so each bot render lands before the following doc commit — the branch tip
is a normal user commit, so
ci.ymlruns against it (the bot pushes withGITHUB_TOKEN, whichdoes not re-trigger workflows).
Notes
shifting the cited lines
190/364→191/365. Updated.126/289occurrences remain on purpose: the specnotefields recording the289 -> 290and126 -> 208transitions, and the illustrative example inscripts/patch_gallery_card.py's docstring/comment. Neither is a live stat.